Feature/fix write method #145
Conversation
|
@matt-l-w r? |
|
Doesn't look like the Unicode branch will get tested - might be nice to add in a case for that... Otherwise looks good! |
|
|
||
|
|
||
| @pytest.fixture | ||
| def tempdir(): |
There was a problem hiding this comment.
pytest provides a handy tmpdir fixture
| try: | ||
| f.write(unicode(json.dumps(data, indent=4))) | ||
| except NameError: | ||
| f.write(json.dumps(data, indent=4)) |
There was a problem hiding this comment.
Instead of using json.dumps try json.dump as this returns a file-like object and shouldn't require the try/except.
There was a problem hiding this comment.
I'm running into an error with py27 when using json.dump
TypeError: write() argument 1 must be unicode, not str
def test_write_results_to_file(tmpdir, mocker):
axe = Axe(mocker.MagicMock())
data = {"testKey": "testValue"}
filename = path.join(str(tmpdir), "results.json")
axe.write_results(data, filename)
def write_results(self, data, name="results.json"):
"""
Write JSON to file with the specified name.
:param name: Name of file to be written to.
:param output: JSON object.
"""
with open(name, "w", encoding="utf8") as f:
json.dump(data, f)
There was a problem hiding this comment.
Ugh, sorry - that sucks. You could consider using futures or six to make this code look a little nicer, but I'm not sure if it's worth the additional dependency.
| try: | ||
| from unittest.mock import MagicMock | ||
| except ImportError: | ||
| from mock import MagicMock |
There was a problem hiding this comment.
You might want to consider https://github.com/pytest-dev/pytest-mock/
3 participants
building off of #144 by @matt-l-w
fixed mock import error